Bahmni Event Log Service version to be managed by Maven

Description

Currently Bahmni Event Log Service module is a Maven project, but the version managed by the pom.xml is not correct:
See the master branch:

(here)

In fact, it seems that the version is not managed anywhere at all, except in the branch name in which the code is.

Modify Bahmni Event Log Service to maintain the version in Maven.

The artifact built by Maven is also not suffixed by the version number. It could be good to change this too.

PR link: https://github.com/Bahmni/event-log-service/pull/2

Activity

Show:
Romain Buisson
April 18, 2018, 2:39 PM

Comments are left on the PR.
Let's keep the conversation here so pasting comment from GitHub PR:

@rbuisson @angshu If we merge this PR, after v0.91 release if user just do yum install bahmni-event-log-service, it will install bahmni-event-log-service v1.0-snapshot (which is actually v0.90) not bahmni-event-log-service v0.91. right?

, I believe Bahmni event log service would be installed on 1.0-SNAPSHOT if it is actually released as an RPM. In theory RPMs should be packaged only when the artefact is released. So when Bahmni event log service is released in 1.0, that would make sense to have the RPM version matching the Maven version, ie, 1.0.

Would that be a problem?
let us know what you think of this?

Angshuman Sarkar
May 12, 2018, 2:56 PM

Actually making this change has no effect in RPM version. I would rather use a 1.0 release rather than downgrading to 0.91. Eventually we would want that a Bahmni version consists of many different packages with different versions.

Darius Jazayeri
May 16, 2018, 11:34 PM

does Angshu's answer clarify what to do next here?

Romain Buisson
May 18, 2018, 7:39 AM

Yes it does.


The Event Log Service has currently never been released (with Maven at least). Maven version is and always has been 1.0-SNAPSHOT:

That's the point of my JIRA ticket here. Should we enforce a process of Maven releasing this app?

Darius Jazayeri
May 18, 2018, 7:17 PM

Yes we should start doing that, for all the Bahmni modules. But I think it's unlikely to happen during the 0.91 release.

Fixed

Assignee

Romain Buisson

Reporter

Romain Buisson

Labels

None

Units

None

PercentDone

None

DueTime

None

Clients

None

External issue ID

None

UAT Assignee

None

Reviewer

None

Components

Sprint

0.93 Product M3

Fix versions

Configure