Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Appointments: Allow saving Speciality entities

Description

Currently and do not support saving Specialities. Only get methods are there.

Add the required methods and logic to save such entities.

Add as well the appropriate unit tests.

Activity

Romain Buisson October 9, 2019 at 12:25 PM

, thanks for the edits on the PR. Now merged .

Moving to Ready for QA

Romain Buisson October 2, 2019 at 7:10 AM

Understood. Thanks , we'll leave the ticket for its current scope then. /api side only.

I will review the PR asap.

Rurangirwa Bailly October 1, 2019 at 5:02 PM

Do we also have to provide a save controller method for specialties under this ticket?

I'd propose we do the REST Controller feature on a separate ticket

Looks like it’ll involve

  • adding a description class (...like AppointmentServiceDescription)

  • a mapper class (...like AppointmentServiceMapper)

  • a test class for the mapper (...like AppointmentServiceDefinitionMapperTest),

  • a #defineAppointmentSpeciality method into the SpecialityController and corresponding unit test into SpecialityControllerTest

I mainly wanted this #save method because I wanted to call it from the initializer module which doesn’t require controllers.

 

Romain Buisson September 30, 2019 at 4:20 PM
Edited

, not mentioned in the issue description, but I think while you are at it, you could maybe create the SpecialityController. Would that be ok?

Romain Buisson September 30, 2019 at 12:41 PM

PR done by :

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Labels

Components

Sprint

Fix versions

Priority

Created September 27, 2019 at 9:44 AM
Updated September 21, 2021 at 2:50 PM
Resolved September 21, 2021 at 2:50 PM